Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added testcases for issue #67 #119

Closed
wants to merge 11 commits into from
Closed

added testcases for issue #67 #119

wants to merge 11 commits into from

Conversation

sgehrig
Copy link

@sgehrig sgehrig commented Feb 7, 2017

see issue #67

bfanger and others added 11 commits December 30, 2016 14:25
Because FuelPHP has a Package class, which isn’t an @annotation the following error occurs:

> [Semantical Error] The class "package" is not annotated with @annotation. Are you sure this class can be used as annotation? If so, then you need to add @annotation to the _class_ doc comment of "package". If it is indeed no annotation, then you need to add @IgnoreAnnotation("package") to the _class_ doc comment of ...

Using @IgnoreAnnotation("package") won’t help because this issue also affects the AnnotationReader->preParser, so this error also occurs when trying to extract the @IgnoreAnnotations
…mpleAnnotationReader into the SimpleAnnotationReaderTest
…dy-autoloaded-classes-1.3.x' into 1.3.x

Close #110
Backport #110
@Ocramius Ocramius mentioned this pull request Feb 7, 2017
@Ocramius Ocramius added the bug label Feb 7, 2017
@Ocramius Ocramius changed the base branch from 1.3.x to master July 22, 2017 09:17
@sgehrig
Copy link
Author

sgehrig commented Jan 17, 2018

Any news on this one?

@greg0ire greg0ire changed the base branch from master to 1.12.x January 1, 2021 19:16
@derrabus derrabus changed the base branch from 1.12.x to 1.14.x August 14, 2023 09:56
@derrabus
Copy link
Member

I don't think, it's worth fixing this issue at this point. Closing.

@derrabus derrabus closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants