Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests #411

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Improve tests #411

merged 2 commits into from
Jul 16, 2021

Conversation

greg0ire
Copy link
Member

AbstractReaderTest relied on an annotation defined in DocParserTest. As
a consequence, running extending tests by themselves failed.

@greg0ire greg0ire marked this pull request as draft April 24, 2021 13:08
@greg0ire greg0ire closed this Apr 24, 2021
@greg0ire greg0ire reopened this Apr 24, 2021
@greg0ire greg0ire closed this May 2, 2021
@greg0ire greg0ire reopened this May 2, 2021
This class is used in a test that checks that annotations that are
supposed to be ignored are indeed ignored.
AbstractReaderTest relied on an annotation defined in DocParserTest. As
a consequence, running extending tests by themselves failed.
@greg0ire greg0ire marked this pull request as ready for review July 15, 2021 20:50
@greg0ire greg0ire merged commit 092a246 into doctrine:1.13.x Jul 16, 2021
@greg0ire greg0ire deleted the improve-tests branch July 16, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants