-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a test case with switch cases containing return #145
Conversation
Seeing this in one of my project when trying to upgrade to Maybe 2 sniffers that collide ? |
@Lctrs thanks for you PR! Would you please move your test to another file? We're trying to isolate things as much as possible and only modifying existing ones when adding a sniff that requires change there.
That does seem to be the case. |
@lcobucci Done. I tried to add differents testing cases :
|
@Lctrs that's awesome, thanks for! I'll take a look at it ASAP. |
I just tested locally with #146 and it fixed the problem for me. 🎉 |
Hmm, we can't get this through unless green though: is the failure related to this patch? |
Moving to |
Thanks for the ping! (closing: I think the process is not needed for now) |
No description provided.