-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not require space after case #146
Do not require space after case #146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to go as 7.0.1
, right @doctrine/coding-standard-approvers?
@carusogabriel if that's the case the label should probably not be "improvement". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is the correct fix. I mean, depending on the usage we should have a space before of break:
foreach (blah() as $item) {
if (something()) {
echo 'doing this...';
break;
}
echo 'doing that...';
}
Can we have this as a test too?
Two minutes after I posted this my brain started functioning properly and I realised I just said non-sense in this comment. I'm sorry.
I swear am not on drugs (maybe that's the problem 🤪)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant to request changes (this old mobile UI isn't my friend)...
@lcobucci is initializing I'll extract tests, wanted to do so for a long time already :) |
8a8cf3f
Hmm, release |
I think I missed this one. Currently I cannot write
but have to write
Which is IMO not desired. So this drops the requirement to have space after
case
.