Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxyGenerator::isShortIdentifierGetter in PHP 7.1 does not support nullable types #761

Closed
aurimasniekis opened this issue Jan 13, 2017 · 0 comments
Closed

ProxyGenerator::isShortIdentifierGetter in PHP 7.1 does not support nullable types #761

aurimasniekis opened this issue Jan 13, 2017 · 0 comments
Assignees
@Ocramius
Labels
Bug
Milestone
2.7.2

Comments

@aurimasniekis
Copy link
Contributor

ProxyGenerator::isShortIdentifierGetter does not work with PHP7.1 nullable return types.

Does not work

public function getId() : ?int

Works

public function getId() : int

If I understood correctly the ProxyGenerator::PATTERN_MATCH_ID_METHOD should be updated to include question mark in return type and test cases to have case with nullable return type.
aurimasniekis added a commit to aurimasniekis/common that referenced this issue Jan 13, 2017
@aurimasniekis
doctrine#761 Added support for PHP 7.1 identifier nullable return type
5a29148
@aurimasniekis aurimasniekis mentioned this issue Jan 13, 2017
Closed
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 s/$field/$fieldName
61766f3
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 dropped unneeded child class used to test PHP 7.1 specifically
04ff075
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 restored pre-patch whitespace change
c049b78
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 removed unused imports
0714019
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 testing PHP5 identifier getter as well (avoids empty data p…
de1551a 
…rovider)
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 renamed test class to better reflect its purpose
71c5590
@Ocramius Ocramius mentioned this issue Jan 13, 2017
Merged
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
Merge pull request #763 from doctrine/fix/#761-#762-support-nullable-…
56fff71 
…identifier-hint-in-proxies

Fix #761, #762: support nullable identifier hint in proxies
@Ocramius Ocramius added this to the 2.7.2 milestone Jan 13, 2017
@Ocramius Ocramius added the Bug label Jan 13, 2017
@Ocramius Ocramius self-assigned this Jan 13, 2017
Ocramius pushed a commit that referenced this issue Jan 13, 2017
@aurimasniekis @Ocramius
#761 Added support for PHP 7.1 identifier nullable return type
cebbdf4
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 s/$field/$fieldName
a1bdf87
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 dropped unneeded child class used to test PHP 7.1 specifically
61e463a
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 restored pre-patch whitespace change
c0e3d29
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 removed unused imports
8e83a34
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 testing PHP5 identifier getter as well (avoids empty data p…
910d29f 
…rovider)
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
#761 #762 renamed test class to better reflect its purpose
3a3d246
Ocramius added a commit that referenced this issue Jan 13, 2017
@Ocramius
Merge branch 'fix/#761-#762-support-nullable-identifier-hint-in-proxi…
9302970 
…es-2.7' into 2.7

Backport #761
Backport #762
Backport #763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ocramius Ocramius

Labels
Bug
Projects
None yet
Milestone
2.7.2
Development

No branches or pull requests
2 participants
@aurimasniekis @Ocramius