Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Debug::export ArrayIterator dumps the internal storage variable #206

Merged
merged 2 commits into from Jan 25, 2013

Conversation

Projects
None yet
4 participants
Contributor

Slamdunk commented Oct 19, 2012

Following my previous PR #191 I found also ArrayIterator needs special behaviour.

Hello,

thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link:

http://doctrine-project.org/jira/browse/DCOM-127

@Baachi Baachi commented on an outdated diff Oct 19, 2012

lib/Doctrine/Common/Util/Debug.php
@@ -104,7 +104,7 @@ public static function export($var, $maxDepth)
$return->__PROXY_INITIALIZED__ = $var->__isInitialized();
}
- if ($var instanceof \ArrayObject) {
+ if ($var instanceof \ArrayObject or $var instanceof \ArrayIterator) {
@Baachi

Baachi Oct 19, 2012

or should be ||

guilhermeblanco added a commit that referenced this pull request Jan 25, 2013

Merge pull request #206 from Slamdunk/hotfix/debug-export-arrayiterator
Debug::export ArrayIterator dumps the internal storage variable

@guilhermeblanco guilhermeblanco merged commit db84fc1 into doctrine:master Jan 25, 2013

1 check passed

default The Travis build passed
Details

@Slamdunk Slamdunk deleted the Slamdunk:hotfix/debug-export-arrayiterator branch Jul 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment