Add a new method to use a filter before extracting the metadata #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thank you for positing this Pull Request. I have automatically opened an issue on our Jira Bug Tracker for you with the details of this Pull-Request. See the Link: |
|
|
||
| $driver = $this->getDriver(); | ||
| $metadata = array(); | ||
| foreach ($driver->getFilteredClassNames($filter) as $className) { |
There was a problem hiding this comment.
this method is not part of the Driver interface (and cannot be added as it would be a BC break)
|
This should be closed IMO. the implementation is currently broken as it assumes an extra method on the driver, which is wrong. To do it right, it would require adding the method in the ClassMetadataFactory interface and updating the MappingDriver interface with a new method. But both changes are BC breaks and so cannot be done until 3.0 |
This was referenced Dec 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I have notice that, when you use the doctrine:mapping:convert and doctrine:mapping:import command in symfony, the filter is added after all the metadata are extracting from the database.
In this case, when you have a table with no primary key for example, you cannot extract the mapping for only one entity.
I have also made a pull-request into the doctrineBundle and doctrine2 to fix this issue.
doctrine/DoctrineBundle#161
doctrine/orm#603
What are your thought about my issue?