[WIP] Abstract Mapping namespace into common code #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all implementations
|
This still needs to move over the tests. |
| * | ||
| * @param Doctrine\Common\Cache\Cache $cacheDriver | ||
| */ | ||
| public function setCacheDriver($cacheDriver) |
|
You might want to consider using my metadata library as there is some code in common, and it has some more features which might come in handy in the future (like merging metadata, lazy-loading drivers, metadata on interfaces). Another improvement would be to extract the finding logic to a separate class and inject that because right now if you want to customize this, you need to duplicate the logic in all drivers instead of just one place (see https://github.com/schmittjoh/metadata/blob/master/src/Metadata/Driver/AbstractFileDriver.php#L14). |
|
@schmittjoh that migration path is too steep for now. I will just rip the ORM mapping core out, which will be much easier to cope for in the first refactoring round. |
|
@schmittjoh merging over different types (xml, annotation, yaml?) |
|
@henrikbjorn, yeah it doesn't matter what source the data is coming from. @beberlei, yeah no need to rush this. However, extracting the _findMappingFile() method to a dedicated class seems doable no? It would save some code duplication, e.g. we wouldn't need a simplified driver, but only a different file locator. |
|
Then metadata integration would be useful as u can only use one kind of mapping right now i think |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Nov 1, 2011
Commits ------- 661421f [Doctrine] Remove AbstractDoctrineBundle and move code into Doctrine Bridge Discussion ---------- [WIP] [Doctrine] Remove abtract doctrine bundle Remove AbstractDoctrineBundle and move code into Doctrine Bridge. It is a BC break because all the "other" Doctrine Bundles MongoDB ODM, CouchDB ODM and PHPCR need to be updated to cope with this. I will prepare PRs for them aswell and then remove the [WIP] here. Bug fix: no Feature addition: no Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #2463 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:32:51 -0700 Here are all 3 PRs, can we coordinate on merging them somehow? https://github.com/symfony/DoctrineMongoDBBundle/pull/50 symfony-cmf/symfony-cmf#118 doctrine/DoctrineCouchDBBundle#4 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:33:38 -0700 Ping @lsmith77 @jwage --------------------------------------------------------------------------- by lsmith77 at 2011/10/26 12:35:29 -0700 all good for me .. --------------------------------------------------------------------------- by stof at 2011/10/26 14:58:01 -0700 Well, this does not fix #2463. A change done in the bridge will still be able to break the service definitions of the other bundles or require tricky stuff to keep different versions of the logic. --------------------------------------------------------------------------- by beberlei at 2011/10/26 22:49:39 -0700 @stof true, that is what doctrine/common#71 will be about. --------------------------------------------------------------------------- by stloyd at 2011/10/26 23:51:25 -0700 Comment just for linking cross PRs and for watching ;-) doctrine/common#71 --------------------------------------------------------------------------- by lsmith77 at 2011/10/31 08:18:45 -0700 please add forward compatibly into symfony 2.0 as per #2522 --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:11:34 -0700 This doesn't make sense imho, since the number of people using the doctrine extension is 4 and everybody also prepared their pull request for this. The problem is really that we need a branch for the MongoDB Bundle --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:40:49 -0700 @fabpot i created a branch in MongoDBBundle for 2.0 so this is ready to be merged.
beberlei
pushed a commit
to doctrine/DoctrineBundle
that referenced
this pull request
Nov 17, 2011
Commits ------- 661421f [Doctrine] Remove AbstractDoctrineBundle and move code into Doctrine Bridge Discussion ---------- [WIP] [Doctrine] Remove abtract doctrine bundle Remove AbstractDoctrineBundle and move code into Doctrine Bridge. It is a BC break because all the "other" Doctrine Bundles MongoDB ODM, CouchDB ODM and PHPCR need to be updated to cope with this. I will prepare PRs for them aswell and then remove the [WIP] here. Bug fix: no Feature addition: no Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #2463 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:32:51 -0700 Here are all 3 PRs, can we coordinate on merging them somehow? https://github.com/symfony/DoctrineMongoDBBundle/pull/50 symfony-cmf/symfony-cmf#118 doctrine/DoctrineCouchDBBundle#4 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:33:38 -0700 Ping @lsmith77 @jwage --------------------------------------------------------------------------- by lsmith77 at 2011/10/26 12:35:29 -0700 all good for me .. --------------------------------------------------------------------------- by stof at 2011/10/26 14:58:01 -0700 Well, this does not fix #2463. A change done in the bridge will still be able to break the service definitions of the other bundles or require tricky stuff to keep different versions of the logic. --------------------------------------------------------------------------- by beberlei at 2011/10/26 22:49:39 -0700 @stof true, that is what doctrine/common#71 will be about. --------------------------------------------------------------------------- by stloyd at 2011/10/26 23:51:25 -0700 Comment just for linking cross PRs and for watching ;-) doctrine/common#71 --------------------------------------------------------------------------- by lsmith77 at 2011/10/31 08:18:45 -0700 please add forward compatibly into symfony 2.0 as per #2522 --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:11:34 -0700 This doesn't make sense imho, since the number of people using the doctrine extension is 4 and everybody also prepared their pull request for this. The problem is really that we need a branch for the MongoDB Bundle --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:40:49 -0700 @fabpot i created a branch in MongoDBBundle for 2.0 so this is ready to be merged.
fabpot
added a commit
to symfony/doctrine-bridge
that referenced
this pull request
Nov 18, 2011
Commits ------- 661421f [Doctrine] Remove AbstractDoctrineBundle and move code into Doctrine Bridge Discussion ---------- [WIP] [Doctrine] Remove abtract doctrine bundle Remove AbstractDoctrineBundle and move code into Doctrine Bridge. It is a BC break because all the "other" Doctrine Bundles MongoDB ODM, CouchDB ODM and PHPCR need to be updated to cope with this. I will prepare PRs for them aswell and then remove the [WIP] here. Bug fix: no Feature addition: no Backwards compatibility break: yes Symfony2 tests pass: yes Fixes the following tickets: #2463 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:32:51 -0700 Here are all 3 PRs, can we coordinate on merging them somehow? https://github.com/symfony/DoctrineMongoDBBundle/pull/50 symfony-cmf/symfony-cmf#118 doctrine/DoctrineCouchDBBundle#4 --------------------------------------------------------------------------- by beberlei at 2011/10/26 12:33:38 -0700 Ping @lsmith77 @jwage --------------------------------------------------------------------------- by lsmith77 at 2011/10/26 12:35:29 -0700 all good for me .. --------------------------------------------------------------------------- by stof at 2011/10/26 14:58:01 -0700 Well, this does not fix #2463. A change done in the bridge will still be able to break the service definitions of the other bundles or require tricky stuff to keep different versions of the logic. --------------------------------------------------------------------------- by beberlei at 2011/10/26 22:49:39 -0700 @stof true, that is what doctrine/common#71 will be about. --------------------------------------------------------------------------- by stloyd at 2011/10/26 23:51:25 -0700 Comment just for linking cross PRs and for watching ;-) doctrine/common#71 --------------------------------------------------------------------------- by lsmith77 at 2011/10/31 08:18:45 -0700 please add forward compatibly into symfony 2.0 as per #2522 --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:11:34 -0700 This doesn't make sense imho, since the number of people using the doctrine extension is 4 and everybody also prepared their pull request for this. The problem is really that we need a branch for the MongoDB Bundle --------------------------------------------------------------------------- by beberlei at 2011/11/01 05:40:49 -0700 @fabpot i created a branch in MongoDBBundle for 2.0 so this is ready to be merged.
| * Whether the class with the specified name is transient. Only non-transient | ||
| * classes, that is entities and mapped superclasses, should have their metadata loaded. | ||
| * A class is non-transient if it is annotated with either @Entity or | ||
| * @MappedSuperclass in the class doc block. |
There was a problem hiding this comment.
This docblock should be revisited since it's to ORM specific.
|
+1 on this, great enhancement. |
|
|
||
| $iterator = new \RecursiveIteratorIterator( | ||
| new \RecursiveDirectoryIterator($path), | ||
| \RecursiveIteratorIterator::LEAVES_ONLY |
beberlei
added a commit
that referenced
this pull request
Nov 28, 2011
Extracted Abstract Mapping Driver & ClassMetadataFactory code from the ORM to be generically used by all Persistence implementations.
|
i guess i will wait for a CouchDB ODM update to see what needs to be done in PHPCR ODM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract Mapping namespace into common code that can be shared across all implementations