-
-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop packages available stand-alone #893
Conversation
You can get a stack trace for the deprecation by using |
I'm totally in favor of this change. |
The deprecations were caused due to using lowest dependencies in the lock file, which means testing PHPUnit 7.0 on PHP 7.4. I've removed the lock file altogether and added a build stage to test against lowest deps. Everywhere else we now test highest deps. |
ba283d6
to
897b7a1
Compare
.travis.yml
Outdated
- stage: Test | ||
php: 7.1 | ||
install: | ||
- travis_retry composer -n --prefer-source --prefer-lowest update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why using --prefer-source
(while persisting the composer cache in the Travis cache at the same time) ? Using --prefer-dist
will benefit from the persisted cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW: Using --no-interaction
is more descriptive than just -n
and makes the travis-file easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I’ll update this 👍
897b7a1
to
85a5afe
Compare
9c59335
to
4626792
Compare
761e5fe
to
3af83a9
Compare
3af83a9
to
81a028c
Compare
With the migration to persistence 2.0 requiring a new major release, it would be a good time to drop all packages that we've extracted into standalone packages. This keeps necessary functionality (e.g. proxy logic) around and supported, while at the same time removing the need for future major releases when another package (e.g. Annotations, Collections, etc.) release a new major version.
Note that we have for a while suggested that people don't rely on doctrine/common for functionality like annotations, inflector, etc., so this BC break in a major release should not be a big burden on the ecosystem.
Regardless, packages still depending on doctrine/common are encouraged to depend on
"doctrine/common": "^2.13 || ^3.0"
as well as the package for the functionality they need while we make this transition.