Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop packages available stand-alone #893

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented May 18, 2020

With the migration to persistence 2.0 requiring a new major release, it would be a good time to drop all packages that we've extracted into standalone packages. This keeps necessary functionality (e.g. proxy logic) around and supported, while at the same time removing the need for future major releases when another package (e.g. Annotations, Collections, etc.) release a new major version.

Note that we have for a while suggested that people don't rely on doctrine/common for functionality like annotations, inflector, etc., so this BC break in a major release should not be a big burden on the ecosystem.

Regardless, packages still depending on doctrine/common are encouraged to depend on "doctrine/common": "^2.13 || ^3.0" as well as the package for the functionality they need while we make this transition.

@alcaeus alcaeus added this to the 3.0 milestone May 18, 2020
@alcaeus alcaeus requested a review from greg0ire May 18, 2020 11:37
@alcaeus alcaeus self-assigned this May 18, 2020
@greg0ire
Copy link
Member

You can get a stack trace for the deprecation by using SYMFONY_DEPRECATIONS_HELPER=/toString/

@stof
Copy link
Member

stof commented May 18, 2020

I'm totally in favor of this change.

@alcaeus
Copy link
Member Author

alcaeus commented May 18, 2020

The deprecations were caused due to using lowest dependencies in the lock file, which means testing PHPUnit 7.0 on PHP 7.4. I've removed the lock file altogether and added a build stage to test against lowest deps. Everywhere else we now test highest deps.

.travis.yml Outdated
- stage: Test
php: 7.1
install:
- travis_retry composer -n --prefer-source --prefer-lowest update
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why using --prefer-source (while persisting the composer cache in the Travis cache at the same time) ? Using --prefer-dist will benefit from the persisted cache.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW: Using --no-interaction is more descriptive than just -n and makes the travis-file easier to read.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I’ll update this 👍

@alcaeus alcaeus force-pushed the drop-extracted-packages branch 2 times, most recently from 9c59335 to 4626792 Compare May 25, 2020 14:25
.travis.yml Outdated Show resolved Hide resolved
@alcaeus alcaeus force-pushed the drop-extracted-packages branch 2 times, most recently from 761e5fe to 3af83a9 Compare May 25, 2020 20:18
@alcaeus alcaeus merged commit 05ab204 into master May 25, 2020
@alcaeus alcaeus deleted the drop-extracted-packages branch May 25, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants