Address commonexception deprecation #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what we do on other doctrine packages.
The exception we were extending is deprecated.
MarcBrillault
force-pushed
the
address-commonexception-deprecation
branch
from
8e90bf2
to
44ca930
Compare
greg0ire
approved these changes
Jun 16, 2022
SenseException
approved these changes
Jun 16, 2022
There was a problem hiding this comment.
Looks good, but @greg0ire how are BC breaks handled in this repo that 1.5 to 1.6 introduce them?
|
@SenseException Marc is my colleague, and we wrote this PR together. In particular, this sentence: "We don't think anyone catches this exception in a |
|
I see data-fixtures mostly in a dev env in projects, which is why I approved the PR. I wanted to be sure that nothing was missed with these changes and that the chosen version was on purpose. |
|
Thanks @MarcBrillault ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.