Fixed pg not supporting aggretated functions wth "FOR UPDATE"

doctrine · Jul 1, 2012 · 03840fc · 03840fc
1 parent 024410a
commit 03840fc
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/Doctrine/DBAL/Connection.php b/lib/Doctrine/DBAL/Connection.php
@@ -555,12 +555,16 @@ public function upsert($tableName, array $data, array $identifier, array $types
             list ($sql, $params, $types) = $this->_platform->getUpsertSql($tableName, $data, $identifier, $types);
             return $this->executeUpdate($sql, $params, $types);
         } else {
-            $sql = 'SELECT COUNT(*) FROM ' . $tableName
+            $sql = 'SELECT ' . implode(', ', array_keys($identifier)) . ' FROM ' . $tableName
                  . ' WHERE ' . implode(' = ? AND ', array_keys($identifier))
                  . ' = ?'
                  . ' ' . $this->_platform->getWriteLockSQL();
 
-            if ($this->fetchColumn($sql, array_values($identifier))) {
+            $stmt = $this->executeQuery($sql, array_values($identifier));
+            $haveRows = (bool)$stmt->fetch(PDO::FETCH_NUM);
+            $stmt->closeCursor();
+
+            if ($haveRows) {
                 return $this->update($tableName, $data, $identifier, $types);
             } else {
                 return $this->insert($tableName, $data, $types);