Deprecate AbstractMySQLPlatform::getColumnTypeSQLSnippets() (#6213)

|      Q       |   A
|------------- | -----------
| Type         | improvement
| Fixed issues |
#6202 (comment)

#### Summary

Deprecates `AbstractMySQLPlatform::getColumnTypeSQLSnippets()`

~~Needs to be rebased after #6202
got merged upstream.~~ Done.

---------

Co-authored-by: Alexander M. Turek <me@derrabus.de>

UPGRADE.md

@@ -8,6 +8,11 @@ awareness about deprecated code.
 
 # Upgrade to 3.8
 
+## Deprecated `AbstractMySQLPlatform::getColumnTypeSQLSnippets()`
+
+`AbstractMySQLPlatform::getColumnTypeSQLSnippets()` has been deprecated.
+Use `AbstractMySQLPlatform::getColumnTypeSQLSnippet()` instead.
+
 ## Deprecated reset methods from `QueryBuilder`
 
 `QueryBuilder::resetQueryParts()` has been deprecated.

psalm.xml.dist

@@ -506,6 +506,11 @@
                 <referencedMethod name="Doctrine\DBAL\Query\QueryBuilder::getQueryParts"/>
                 <referencedMethod name="Doctrine\DBAL\Query\QueryBuilder::resetQueryPart"/>
                 <referencedMethod name="Doctrine\DBAL\Query\QueryBuilder::resetQueryParts"/>
+                <!--
+                    See https://github.com/doctrine/dbal/pull/6202
+                    TODO: remove in 4.0.0
+                -->
+                <referencedMethod name="Doctrine\DBAL\Platforms\AbstractMySQLPlatform::getColumnTypeSQLSnippets" />
 
                 <!-- TODO for PHPUnit 10 -->
                 <referencedMethod name="PHPUnit\Framework\MockObject\Builder\InvocationMocker::withConsecutive"/>

src/Platforms/AbstractMySQLPlatform.php

@@ -398,6 +398,8 @@ public function getListTableColumnsSQL($table, $database = null)
     }
 
     /**
+     * @deprecated Use {@see getColumnTypeSQLSnippet()} instead.
+     *
      * The SQL snippets required to elucidate a column type
      *
      * Returns an array of the form [column type SELECT snippet, additional JOIN statement snippet]
@@ -406,6 +408,13 @@ public function getListTableColumnsSQL($table, $database = null)
      */
     public function getColumnTypeSQLSnippets(string $tableAlias = 'c'): array
     {
+        Deprecation::triggerIfCalledFromOutside(
+            'doctrine/dbal',
+            'https://github.com/doctrine/dbal/pull/6202',
+            'AbstractMySQLPlatform::getColumnTypeSQLSnippets() is deprecated. '
+            . 'Use AbstractMySQLPlatform::getColumnTypeSQLSnippet() instead.',
+        );
+
         return [$this->getColumnTypeSQLSnippet(...func_get_args()), ''];
     }