Skip to content

Commit

Permalink
Merge pull request #2935 from greg0ire/improve_wording
Browse files Browse the repository at this point in the history
Improve deprecation wording in `Doctrine\DBAL\Schema\Column#setOptions()`
  • Loading branch information
Ocramius committed Dec 8, 2017
2 parents cb08c4d + 4256d17 commit 6565790
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions lib/Doctrine/DBAL/Schema/Column.php
Expand Up @@ -121,8 +121,8 @@ public function setOptions(array $options)
if ( ! method_exists($this, $method)) {
// next major: throw an exception
@trigger_error(sprintf(
'The "%s" option is not supported,'.
' setting it is deprecated and will cause an error in 3.0',
'The "%s" column option is not supported,'.
' setting it is deprecated and will cause an error in Doctrine 3.0',
$name
), E_USER_DEPRECATED);

Expand Down
2 changes: 1 addition & 1 deletion tests/Doctrine/Tests/DBAL/Schema/ColumnTest.php
Expand Up @@ -58,7 +58,7 @@ public function testToArray()

/**
* @group legacy
* @expectedDeprecation The "unknown_option" option is not supported, setting it is deprecated and will cause an error in 3.0
* @expectedDeprecation The "unknown_option" column option is not supported, setting it is deprecated and will cause an error in Doctrine 3.0
*/
public function testSettingUnknownOptionIsStillSupported() : void
{
Expand Down

0 comments on commit 6565790

Please sign in to comment.