DBAL-197 - Add blob to registered mapping types and test on all platf…

…orms.
doctrine · Jan 9, 2012 · 854a67d · 854a67d
1 parent 3257459
commit 854a67d
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 4 deletions.
diff --git a/lib/Doctrine/DBAL/Platforms/MsSqlPlatform.php b/lib/Doctrine/DBAL/Platforms/MsSqlPlatform.php
@@ -764,7 +764,7 @@ protected function initializeDoctrineTypeMappings()
             'nvarchar' => 'string',
             'ntext' => 'text',
             'binary' => 'text',
-            'varbinary' => 'text',
+            'varbinary' => 'blob',
             'image' => 'text',
         );
     }

diff --git a/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php b/lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
@@ -679,6 +679,10 @@ protected function initializeDoctrineTypeMappings()
             'decimal'       => 'decimal',
             'numeric'       => 'decimal',
             'year'          => 'date',
+            'longblob'      => 'blob',
+            'blob'          => 'blob',
+            'mediumblob'    => 'blob',
+            'tinyblob'      => 'blob',
         );
     }
 

diff --git a/lib/Doctrine/DBAL/Platforms/OraclePlatform.php b/lib/Doctrine/DBAL/Platforms/OraclePlatform.php
@@ -811,6 +811,7 @@ protected function initializeDoctrineTypeMappings()
             'long raw'          => 'text',
             'rowid'             => 'string',
             'urowid'            => 'string',
+            'blob'              => 'blob',
         );
     }
 

diff --git a/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php b/lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php
@@ -767,6 +767,7 @@ protected function initializeDoctrineTypeMappings()
             'money'         => 'decimal',
             'numeric'       => 'decimal',
             'year'          => 'date',
+            'bytea'         => 'blob',
         );
     }
 

diff --git a/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php b/lib/Doctrine/DBAL/Platforms/SqlitePlatform.php
@@ -479,6 +479,7 @@ protected function initializeDoctrineTypeMappings()
             'real'             => 'float',
             'decimal'          => 'decimal',
             'numeric'          => 'decimal',
+            'blob'             => 'blob',
         );
     }
 

diff --git a/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php b/lib/Doctrine/DBAL/Schema/PostgreSqlSchemaManager.php
@@ -276,9 +276,8 @@ protected function _getPortableTableColumnDefinition($tableColumn)
         $precision = null;
         $scale = null;
 
-        if ($this->_platform->hasDoctrineTypeMappingFor($tableColumn['type'])) {
-            $dbType = strtolower($tableColumn['type']);
-        } else {
+        $dbType = strtolower($tableColumn['type']);
+        if (strlen($tableColumn['domain_type'])) {
             $dbType = strtolower($tableColumn['domain_type']);
             $tableColumn['complete_type'] = $tableColumn['domain_complete_type'];
         }

diff --git a/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php b/tests/Doctrine/Tests/DBAL/Functional/Schema/SchemaManagerFunctionalTestCase.php
@@ -547,6 +547,20 @@ public function testAutomaticallyAppendCommentOnMarkedColumns()
         $this->assertInstanceOf('Doctrine\DBAL\Types\ArrayType', $columns['arr']->getType(), "The Doctrine2 should be detected from comment hint.");
     }
 
+    /**
+     * @group DBAL-197
+     */
+    public function testListTableWithBlob()
+    {
+        $table = new \Doctrine\DBAL\Schema\Table('test_blob_table');
+        $table->addColumn('id', 'integer', array('comment' => 'This is a comment'));
+        $table->addColumn('binarydata', 'blob', array());
+        $table->setPrimaryKey(array('id'));
+
+        $this->_sm->createTable($table);
+        $blobTable = $this->_sm->listTableDetails('test_blob_table');
+    }
+
     /**
      * @param string $name
      * @param array $data