Merge pull request #4517 from morozov/deprecate-connection-expr

Deprecate Connection::$_expr
doctrine · Feb 28, 2021 · 96b4319 · 96b4319
2 parents dac121d + 4c62733
commit 96b4319
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/UPGRADE.md b/UPGRADE.md
@@ -1,3 +1,10 @@
+# Upgrade to 3.1
+
+## Deprecated `Connection::$_expr`
+
+The usage of `Connection::$_expr` by extending classes is deprecated. Use `Connection::getExpressionBuilder()` instead.
+Do not rely on the same builder instance being returned by each invocation.
+
 # Upgrade to 3.0
 
 ## BC BREAK: leading colon in named parameter names not supported

diff --git a/src/Connection.php b/src/Connection.php
@@ -68,7 +68,11 @@ class Connection
     /** @var EventManager */
     protected $_eventManager;
 
-    /** @var ExpressionBuilder */
+    /**
+     * @deprecated Use {@link getExpressionBuilder()} instead.
+     *
+     * @var ExpressionBuilder
+     */
     protected $_expr;
 
     /**