Keep NVARCHAR(MAX) length as -1

doctrine · Jan 20, 2024 · 9a256b9 · 9a256b9
1 parent 81502f0
commit 9a256b9
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/Schema/SQLServerSchemaManager.php b/src/Schema/SQLServerSchemaManager.php
@@ -133,12 +133,20 @@ protected function _getPortableTableColumnDefinition($tableColumn)
 
         switch ($dbType) {
             case 'nchar':
-            case 'nvarchar':
             case 'ntext':
                 // Unicode data requires 2 bytes per character
                 $length /= 2;
                 break;
 
+            case 'nvarchar':
+                if ($length === -1) {
+                    break;
+                }
+
+                // Unicode data requires 2 bytes per character
+                $length /= 2;
+                break;
+
             case 'varchar':
                 // TEXT type is returned as VARCHAR(MAX) with a length of -1
                 if ($length === -1) {

diff --git a/tests/Functional/Schema/SQLServerSchemaManagerTest.php b/tests/Functional/Schema/SQLServerSchemaManagerTest.php
@@ -262,4 +262,19 @@ public function testPkOrdering(): void
         self::assertEquals('colB', $columns[0]);
         self::assertEquals('colA', $columns[1]);
     }
+
+    public function testNvarcharMaxIsLengthMinus1(): void
+    {
+        $sql = 'CREATE TABLE test_nvarchar_max (
+            col_nvarchar_max NVARCHAR(MAX),
+            col_nvarchar NVARCHAR(128)
+        )';
+
+        $this->connection->executeStatement($sql);
+
+        $table = $this->schemaManager->introspectTable('test_nvarchar_max');
+
+        self::assertSame(-1, $table->getColumn('col_nvarchar_max')->getLength());
+        self::assertSame(128, $table->getColumn('col_nvarchar')->getLength());
+    }
 }