Remove "plus/minus sign" code

doctrine · Jun 17, 2024 · b78860b · b78860b
1 parent 62cc9d7
commit b78860b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 11 deletions.
diff --git a/src/Types/BigIntType.php b/src/Types/BigIntType.php
@@ -51,10 +51,6 @@ public function convertToPHPValue(mixed $value, AbstractPlatform $platform): int
             'DBAL assumes values outside of the integer range to be returned as string by the database driver.',
         );
 
-        if (str_starts_with($value, '+') || $value === '-0') {
-            $value = substr($value, 1);
-        }
-
         if ($value === (string) (int) $value) {
             return (int) $value;
         }

diff --git a/tests/Functional/Types/BigIntTypeTest.php b/tests/Functional/Types/BigIntTypeTest.php
@@ -44,20 +44,13 @@ public function testSelectBigInt(string $sqlLiteral, int|string|null $expectedVa
     public static function provideBigIntLiterals(): Generator
     {
         yield 'zero' => ['0', 0];
-        yield 'minus zero' => ['-0', 0];
-        yield 'plus zero' => ['+0', 0];
         yield 'null' => ['null', null];
         yield 'positive number' => ['42', 42];
         yield 'negative number' => ['-42', -42];
         yield 'large positive number' => [PHP_INT_SIZE === 4 ? '2147483646' : '9223372036854775806', PHP_INT_MAX - 1];
         yield 'large negative number' => [PHP_INT_SIZE === 4 ? '-2147483647' : '-9223372036854775807', PHP_INT_MIN + 1];
         yield 'largest positive number' => [PHP_INT_SIZE === 4 ? '2147483647' : '9223372036854775807', PHP_INT_MAX];
         yield 'largest negative number' => [PHP_INT_SIZE === 4 ? '-2147483648' : '-9223372036854775808', PHP_INT_MIN];
-
-        yield 'plus largest positive number' => [
-            PHP_INT_SIZE === 4 ? '+2147483647' : '+9223372036854775807',
-            PHP_INT_MAX,
-        ];
     }
 
     public function testUnsignedBigIntOnMySQL(): void