fixed unqualified table name of fk constraints when using schemas

doctrine · Dec 29, 2019 · e144166 · e144166
1 parent c0b3892
commit e144166
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 1 deletion.
diff --git a/lib/Doctrine/DBAL/Schema/ForeignKeyConstraint.php b/lib/Doctrine/DBAL/Schema/ForeignKeyConstraint.php
@@ -218,7 +218,7 @@ public function getUnqualifiedForeignTableName() : string
         $position = strrpos($name, '.');
 
         if ($position !== false) {
-            $name = substr($name, $position);
+            $name = substr($name, $position + 1);
         }
 
         return strtolower($name);

diff --git a/tests/Doctrine/Tests/DBAL/Schema/ForeignKeyConstraintTest.php b/tests/Doctrine/Tests/DBAL/Schema/ForeignKeyConstraintTest.php
@@ -6,6 +6,7 @@
 
 use Doctrine\DBAL\Schema\ForeignKeyConstraint;
 use Doctrine\DBAL\Schema\Index;
+use Doctrine\DBAL\Schema\Table;
 use PHPUnit\Framework\TestCase;
 
 class ForeignKeyConstraintTest extends TestCase
@@ -58,4 +59,30 @@ public static function getIntersectsIndexColumnsData() : iterable
             [['FOO'], true],
         ];
     }
+
+    /**
+     * @param string|Table $foreignTableName
+     *
+     * @group DBAL-1062
+     * @dataProvider getUnqualifiedForeignTableNameData
+     */
+    public function testGetUnqualifiedForeignTableName($foreignTableName, string $expectedUnqualifiedTableName) : void
+    {
+        $foreignKey = new ForeignKeyConstraint(['foo', 'bar'], $foreignTableName, ['fk_foo', 'fk_bar']);
+
+        self::assertSame($expectedUnqualifiedTableName, $foreignKey->getUnqualifiedForeignTableName());
+    }
+
+    /**
+     * @return mixed[][]
+     */
+    public static function getUnqualifiedForeignTableNameData() : iterable
+    {
+        return [
+            ['schema.foreign_table', 'foreign_table'],
+            ['foreign_table', 'foreign_table'],
+            [new Table('schema.foreign_table'), 'foreign_table'],
+            [new Table('foreign_table'), 'foreign_table'],
+        ];
+    }
 }