SQL Server Unique indexes constraint

[j-d]

Hello,
This line is incorrect

dbal/lib/Doctrine/DBAL/Platforms/SQLServerPlatform.php

Line 358 in 61e1f86

$constraint = $this->_appendUniqueConstraintDefinition($constraint, $index);

This issue was introduced in SQL Server 2008 according to https://msdn.microsoft.com/en-us/library/ms188783.aspx.

(And I have SQL Server 2005 and it doesn't work)

[Ocramius]

What exactly is incorrect about it? Can you point to a failure or reproducible test case about it?

[j-d]

Thanks for your prompt response @Ocramius.

I have given it a go here at writting the test and the fix here: #2394

I am not sure how to make a functional test on this project that runs it on SQL Server 2005 (where it breaks). I also don't have an enviroment here to test this test right now; but hopefully you will see what I was trying to do.

Also, I believe this is incorrect:

dbal/lib/Doctrine/DBAL/Platforms/AbstractPlatform.php

Line 3071 in 5f0dfd2

return false;

Because that method is only overwritten by PostgreSql, but according to the MS documentation I referenced above, this appears to be supported on MS SQL Server 2008+; so I have changed it too.

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.