Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are 4x slower on Oracle since DBAL v3.4.0 #5698

Closed
mvorisek opened this issue Sep 27, 2022 · 6 comments
Closed

Tests are 4x slower on Oracle since DBAL v3.4.0 #5698

mvorisek opened this issue Sep 27, 2022 · 6 comments

Comments

@mvorisek
Copy link
Contributor

mvorisek commented Sep 27, 2022

Bug Report

Q A
Version 3.4.0

Summary

Not sure what is exactly the problem, but since upgrade to DBAL v3.4.x, the CI takes ~7 minutes for Oracle vs. ~1.5 minutes before.

Current behaviour

before https://github.com/atk4/data/actions/runs/3133960125/jobs/5087921285#step:17:27, https://github.com/atk4/data/actions/runs/3133376169/jobs/5086678758#step:17:27
after https://github.com/atk4/data/actions/runs/3135574120/jobs/5091417197#step:17:27

Steps to reproduce

run atk4/data tests like in the CI:

https://github.com/atk4/data/blob/c30e90879bbf21ec946d648ee112d32b90edc9fd/.github/workflows/test-unit.yml#L236-L245

@morozov morozov changed the title Oracle is 4x slower since DBAL v3.4.0 Tests are 4x slower on Oracle since DBAL v3.4.0 Sep 27, 2022
@morozov
Copy link
Member

morozov commented Sep 27, 2022

This is not necessarily caused by the DBAL. See doctrine/orm#9839 for example. The DBAL's own test suite became 40% faster as of #5268 (3.4.0).

You'll need to provide more details for this issue to be considered.

@mvorisek
Copy link
Contributor Author

Any idea what the issue can be? Please see the diff - https://github.com/atk4/data/compare/8d1b2b2d3092432f832356226c6d4b4716e4d717 - no other change than DBAL version was made. Tested multiple times, same results.

Also, it seems you blocked me in the past in your GH account, I am sorry if I upset you, but this action stopped a notifications from you nor I am unable to comment on some of your php-src issues.

@morozov
Copy link
Member

morozov commented Sep 28, 2022

I blocked you because communication with you takes a lot of time and energy. You're saying you are sorry but at the same time when requested to provide more details you provide a link to the diff which changes the DBAL version, which is already known. As a result: time spent on interaction leads to zero progress.

@morozov
Copy link
Member

morozov commented Oct 2, 2022

Closing as previously warned in #5508 (comment).

@morozov morozov closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
@mvorisek
Copy link
Contributor Author

before:

image

after:

image

problem is described in #5764, related with #5268 change

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants