SQLParserUtils triggered an error when feeding it Type instances instead of PDO param type ints #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of PDO param type ints.
|
why should it try to convert it to an int ? a strict check does not do conversions |
…parisons when expanding list parameters.
|
Right, my mistake. Looks like the second comparison on the same line was NOT an equality comparison. Should be fixed now. |
beberlei
added a commit
that referenced
this pull request
Mar 24, 2012
SQLParserUtils triggered an error when feeding it Type instances instead of PDO param type ints
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all. If-statement failed when trying to convert
\Doctrine\DBAL\Type\Typeinstances to an int for comparison.