Added parameter default_dbname to pdo_pgsql driver, used to override the default database

[kimhemsoe]

No description provided.

[deeky666]

We should still connect to postgres if the parameter is not set as we will have errors again otherwise.

[kimhemsoe]

No, postgres is the default if dont provide one. Ive tested it.

[deeky666]

@kimhemsoe that is not true. It defaults to a database that is named equally to the connection user. This is what originally caused trouble. See PHP issue and doctrine/DoctrineBundle#402

[billschaller]

@deeky666 @kimhemsoe Ah yes, I was wrong - you can verify this using:

PDO

php -r "$pdo = new PDO('pgsql:host=localhost port=5432', 'your_username', 'your_password');"

If no db matching your username exists, you get:

PDOException: SQLSTATE[08006] [7] FATAL:  database "your_username" does not exist in Command line code on line 1

Call Stack:
    0.0000     125096   1. {main}() Command line code:0
    0.0000     125520   2. PDO->__construct() Command line code:1

pgsql

php -r "$conn = pg_connect('host=localhost port=5432 user=your_username password=your_password');"

If no db matching your username exists, you get:

Warning: pg_connect(): Unable to connect to PostgreSQL server: FATAL:  database "your_username" does not exist in Command line code on line 1

Call Stack:
    0.0000     124792   1. {main}() Command line code:0
    0.0000     124928   2. pg_connect() Command line code:1

[deeky666]

Could you please adjust this test case to the following to cover all variants?

/**
 * @dataProvider getDatabaseParameter
 */
public function testDatabaseParameter($databaseName, $defaultDatabaseName, $expectedDatabaseName)
{
    $params = $this->_conn->getParams();
    $params['dbname'] = $databaseName;
    $params['default_dbname'] = $defaultDatabaseName;

    $connection = new Connection(
        $params,
        $this->_conn->getDriver(),
        $this->_conn->getConfiguration(),
        $this->_conn->getEventManager()
    );

    $this->assertSame(
        $expectedDatabaseName,
        $this->driver->getDatabase($connection)
    );
}

public function getDatabaseParameter()
{
    $params = TestUtil::getConnection()->getParams();
    $realDatabaseName = $params['dbname'];
    $dummyDatabaseName = $realDatabaseName . 'a';

    return array(
        // dbname, default_dbname, expected
        array($realDatabaseName, null, $realDatabaseName),
        array($realDatabaseName, $dummyDatabaseName, $realDatabaseName),
        array(null, $realDatabaseName, $realDatabaseName),
        array(null, null, $this->getDatabaseNameForConnectionWithoutDatabaseNameParameter()),
    );
}

[deeky666]

@kimhemsoe this looks like borken indentation. Can you fix this? After that I'll merge.

[kimhemsoe]

@deeky666 ping

[deeky666]

@kimhemsoe merged, thanks.

[kimhemsoe]

@deeky666 Did you merge into 2.5 too?

[deeky666]

@kimhemsoe no. It is actually an improvement, no? 2.5 only receives bug fixes