[SQLite Platform] doctrine:database:create --if-not-exists fix

[eugene-matvejev]

problem description: doctrine/DoctrineBundle#542

[mikeSimonson]

In sqlite the PRAGMA is "database_list" not "databases".
You will need to fix the tests and verify that the ouput of that PRAGMA is comparable to the output of the others platforms.

[eugene-matvejev]

I tried fix it, basically PRAGMA database_list return array [see below] while database file been created in root directory (or in directory from tests been launched)

whenever I launch it with command:
./vendor/bin/phpunit --configuration tests/travis/sqlite.travis.xml

test_create_database file been created in root, but

    public function testListDatabases()
    {
        if (!$this->_sm->getDatabasePlatform()->supportsCreateDropDatabase()) {
            $this->markTestSkipped('Cannot drop Database client side with this Driver.');
        }

        $this->_sm->dropAndCreateDatabase('test_create_database');
        $databases = $this->_sm->listDatabases();
        /** left for debug purposes */
        $databases_ = [];
        foreach ($databases as $database) {
            $databases_[] = is_array($database) ? strtolower($database['name']) : $database;
        }

        $this->assertContains('test_create_database', $databases_);
    }

$databases content:

Array
(
    [0] => Array
        (
            [seq] => 0
            [name] => main
            [file] => 
        )
    [1] => Array
        (
            [seq] => 1
            [name] => temp
            [file] => 
        )
)

i presume it should detect test_create_database file , what I am doing wrong? I didn't catch =/

[eugene-matvejev]

bump!

[eugene-matvejev]

@mikeSimonson seems you have more experience with SQLIte than me, can you please help?

[sharif9876]

Any updates on this? It's still an issue

[Ocramius]

If it's dead, it should be removed

[Ocramius]

Remove - debugging stuff only while debugging please

[Ocramius]

The return format of SchemaManager#listDatabases() changed: that is a BC break.

[Ocramius]

Please DO ADD a test to demonstrate your issue, rather than modifying existing tests.

[ostrolucky]

Closing, as author never got around to finish this. If you ever intend to finish this, feel free to open new PR. Thanks!