Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OFFSET without LIMIT cause MySQL syntax error. #261

Closed
wants to merge 7 commits into from
Closed

Fix OFFSET without LIMIT cause MySQL syntax error. #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cad1163
Updated doModifyLimitQuery in SQLServerPlatform to handle subqueries …
Jan 22, 2013
7c06b9e
Updated regular expressions in doModifyLimitQuery
Jan 22, 2013
1e8c15d
Set guid type to require SQL comment hint
pkruithof Jan 26, 2013
1db3113
Type hinting for guid type now depends on platform's native guid support
pkruithof Jan 27, 2013
20f3b39
Fixed wrong class names in SQLAzureFederationsSynchronizer
Jan 29, 2013
14a96c1
Merge branch 'master' of https://github.com/doctrine/dbal
Everus Feb 1, 2013
940509f
Fix OFFSET without LIMIT cause MySQL syntax error.
Everus Feb 1, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions lib/Doctrine/DBAL/Platforms/MySqlPlatform.php
View file
Open in desktop
Expand Up @@ -36,6 +36,25 @@
*/
class MySqlPlatform extends AbstractPlatform
{

/**
* Adds MySQL-specific LIMIT clause to the query
* 18446744073709551615 is 2^64-1 maximum of unsigned BIGINT the biggest limit possible
*/
protected function doModifyLimitQuery($query, $limit, $offset)
{
if ($limit !== null) {
$query .= ' LIMIT ' . $limit;
if ($offset !== null) {
$query .= ' OFFSET ' . $offset;
}
}elseif ($offset !== null) {
$query .= ' LIMIT 18446744073709551615 OFFSET ' . $offset;
}

return $query;
}

/**
* {@inheritDoc}
*/
Expand Down
6 changes: 6 additions & 0 deletions tests/Doctrine/Tests/DBAL/Platforms/MySqlPlatformTest.php
View file
Open in desktop
Expand Up @@ -16,6 +16,12 @@ public function createPlatform()
return new MysqlPlatform;
}

public function testdoModifyLimitQuery()
{
$sql=$this->_platform->doModifyLimitQuery('SELECT n FROM Foo', null , 10);
$this->assertEquals('SELECT n FROM Foo LIMIT 18446744073709551615 OFFSET 10',$sql);
}

public function testGenerateMixedCaseTableCreate()
{
$table = new Table("Foo");
Expand Down