Add SQL file logger

[BenMorel]

I've been using a SQL file logger for years, that proved very helpful during development, are you interested to merge it?

It produces an output similar to:

SQL logger starting on Wed, 08 Nov 2017 16:30:05 +0000

Query 1: SELECT ... WHERE t0.id = ?
Parameters: 5
Types: 'integer'
This query: 0.001 seconds; total: 0.001 seconds.

Query 2: SELECT ... WHERE d0_.restaurantId = ? AND d0_.status IN (?)
Parameters: 5, ['active']
Types: 'integer', 102
This query: 0.001 seconds; total: 0.002 seconds.

Query 3: SELECT ... ST_Contains(z0_.boundary, ST_GeomFromWKB(?, 4326)) = 1 AND z0_.status <> ?
Parameters: Brick\Geo\Point(POINT (55.2238832 -21.0401197)), 'deleted'
Types: 'Point', 2
This query: 0.026 seconds; total: 0.028 seconds.

Note: ellipses are mine, the logger outputs the full query.

It writes a compact representation of parameters, representing objects as their class name along with their string representation if available, or their hash otherwise.

[lcobucci]

@BenMorel thanks for your contribution. The logger can indeed be useful but I think not everyone might need it, so maybe you could be offered as a separate package. You can create a small lib that depends on DBAL and provides that SQLLogger implementation. What do you think?

[BenMorel]

I already have it in a repo, that I'm trying to tidy up and split into specific repositories. It's just that the FileLogger does not really belong anywhere and would probably end up in a repo of its own, which would be overkill IMO.

Doctrine already ships with an EchoLogger, so I thought the FileLogger would belong there as well.

[morozov]

I agree with @lcobucci. Only the interface belongs to the package itself. All implementations (including the existing ones) don't. Otherwise, we may end up implementing all possible loggers here.

[Ocramius]

Probably better to generally use a PSR-3 logger? Marco Pivetta http://twitter.com/Ocramius http://ocramius.github.com/

…

On Sun, Nov 12, 2017 at 7:07 PM, Sergei Morozov ***@***.***> wrote: I agree with @lcobucci <https://github.com/lcobucci>. Only the interface belongs to the package itself. All implementations (including the existing ones) don't. Otherwise, we may end up implementing all possible loggers here. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2911 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakNhoMgjrFeLqtkZFMqf6BcgqjBe_ks5s1zP5gaJpZM4QWuIB> .

[BenMorel]

Okay... I thought that basic implementations (the ones that don't require extra packages or extensions) did belong to this package.

[greg0ire]

Quick implementation:

<?php

namespace Svod\Infrastructure\Persistence\Doctrine;

use Doctrine\DBAL\Logging\SQLLogger;
use Psr\Log\LoggerInterface;

final class PsrSQLLogger implements SQLLogger
{
    /**
     * @var LoggerInterface
     */
    private $logger;

    public function __construct(LoggerInterface $logger)
    {
        $this->logger = $logger;
    }

    /**
     * {@inheritDoc}
     */
    public function startQuery($sql, array $params = null, array $types = null)
    {
        $this->logger->debug(
            $sql,
            compact('params', 'types')
        );
    }

    /**
     * {@inheritDoc}
     */
    public function stopQuery()
    {
    }
}

Works for me ™️