fixed annotations of parameter $columns in Table

[LukasVitek]

Q	A
Type	bug
BC Break	no

Fixes #3380.

Summary

Fixed annotations of parameter $columns in Table. Parameter $columns is array of mixed, nowhere in the code does not treated with him as with an array of array.

Before the fix the code, phpStan reported an error with this code:

$table = new Table('tableName');
$table->addUniqueIndex(['col1', 'col2']);

Parameter #1 $columnNames of method Doctrine\DBAL\Schema\Table::addUniqueIndex() expects array<array>, array<int, string> given.

[morozov]

@LukasVitek is this related to #3380? Could you double check if those mixed[][] $columns/$columnNames are actually string[] $columnNames, not mixed[]? See the details in the related ticket.

[LukasVitek]

Actually, yes, issue #3380 is very related.
And yes, it is always assumed that $columns/$columnNames are type of string[],
except for one case here:

dbal/lib/Doctrine/DBAL/Schema/Table.php

Line 274 in 4b4d44f

if (is_numeric($columnName) && is_string($indexColOptions)) {

where it is verified if the variable in the array is type of string.
Should I therefore type of annotations to remake to string[]?

[morozov]

Yes, please use string[] where makes sense and rename the variables from $columns to $columnNames to avoid further confusion.

[morozov]

@LukasVitek please squash and I’ll merge it.

[thewilkybarkid]

columnsAreIndexed() needs updating too.

[morozov]

@LukasVitek please update columnsAreIndexed() as well.

The concern has been resolved.

[morozov]

Thank you @LukasVitek and @thewilkybarkid.

[leofeyer]

I'm afraid this change breaks indexes with a fixed length. We have an index named path(768), which now throws a There is no column with name 'path(768)' exception, because the following code has been removed in the Table::_createIndex() method:

        if (is_numeric($columnName) && is_string($indexColOptions)) {
            $columnName = $indexColOptions;
        }

[Ocramius]

@leofeyer can you please report a new issue? Got a test case for it?

[leofeyer]

@Ocramius Sure, here you go: #3409