Issue #950: Fixed cardinality issue where subquery could return more than one row #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rn more than one row in getListTableForeignKeysSQL function
Ocramius
suggested changes
Jan 2, 2019
|
@Ocramius Okay, what branch should I commit this to then? |
|
Please target master
…On Wed, 2 Jan 2019, 17:02 jwilson-cee ***@***.*** wrote:
@Ocramius <https://github.com/Ocramius> Okay, what branch should I commit
this to then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3421 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAJakNuvxPLgNEx7yQ-CPt99zgSXZ7bwks5u_NgugaJpZM4Zm2Nd>
.
|
|
As the underlying issue still exists and PostgreSqlPlatform.php has to be altered manually after each composer update.... When will this be fixed? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cardinality issue where subquery could return more than than one row in getListTableForeignKeysSQL function
Summary
Replaced "=" with "IN" in the query in the PostgreSqlPlatform->getListTableForeignKeysSQL() function to avoid getting a cardinality violation error thrown