Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of hard-coded default values of maximum field lengths #3586

Merged
merged 1 commit into from Jun 5, 2019
Merged

Get rid of hard-coded default values of maximum field lengths #3586

merged 1 commit into from Jun 5, 2019

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 4, 2019 •
edited

Q A
Type improvement
BC Break yes

Fixes #3263.

Summary:

  1. The proposal from Get rid of hard-coded default values of maximum field lengths #3263 has been implemented.
  2. Two sets of unit and integration tests which consistently cover all supported platforms have been added. Some existing tests which duplicated the new ones have been removed.

TODO:

  • Document breaking changes.

@morozov morozov force-pushed the issues/3263 branch 2 times, most recently from 2190738 to d985f60 Compare June 4, 2019 14:54
@jwage
Copy link
Member

jwage commented Jun 4, 2019

Cool! Let me know once you are ready for a review.

@morozov morozov requested a review from jwage June 4, 2019 20:34
@morozov morozov merged commit b62acb6 into doctrine:develop Jun 5, 2019
@morozov morozov deleted the issues/3263 branch June 5, 2019 14:55
@morozov morozov self-assigned this Jun 6, 2019
@morozov morozov mentioned this pull request Jun 7, 2019
Closed
morozov added a commit that referenced this pull request Jun 13, 2019
@morozov
Merge pull request #3586 from morozov/issues/3263
f21cd89 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3586 from morozov/issues/3263
834f470 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3586 from morozov/issues/3263
bff2f33 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit that referenced this pull request Jun 27, 2019
@morozov
Merge pull request #3586 from morozov/issues/3263
2f84915 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3586 from morozov/issues/3263
b4b20a8 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3586 from morozov/issues/3263
e13540c 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit to morozov/dbal that referenced this pull request Aug 26, 2019
@morozov
Merge pull request doctrine#3586 from morozov/issues/3263
00d947c 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit to morozov/dbal that referenced this pull request Aug 27, 2019
@morozov
Merge pull request doctrine#3586 from morozov/issues/3263
99351ee 
Get rid of hard-coded default values of maximum field lengths
morozov added a commit that referenced this pull request Nov 2, 2019
@morozov
Merge pull request #3586 from morozov/issues/3263
be458b5 
Get rid of hard-coded default values of maximum field lengths
@morozov morozov added this to the 3.0.0 milestone Nov 2, 2019
@morozov morozov mentioned this pull request Jul 21, 2021
Merged
@morozov morozov mentioned this pull request Aug 27, 2021
Merged
@morozov morozov mentioned this pull request Nov 2, 2021
Closed
@Tobion Tobion mentioned this pull request Apr 24, 2022
Open
This was referenced May 3, 2022
Merged
Merged
Merged
Merged
Merged
@morozov morozov mentioned this pull request May 14, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jwage jwage jwage approved these changes

Assignees

@morozov morozov

Labels
BC Break Columns Improvement Platforms
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @jwage