Fix breaks named parameters in Oracle

[eisberg]

Q	A
Type	bug
BC Break	yes

Fixes #3722
Closes #3779

Summary

Fix breaks named parameters in Oracle ( see issue #3722 )

[morozov]

@eisberg could you also add a test?

[morozov]

The testQueryConversion test does not cover all use cases because it calls the executeQuery method on the connection object. In this case, the named parameters are transformed into positional ones.

Thanks for bringing this up. We probably need to get rid of this behavior since, on the one hand, it doesn't make any sense for the drivers that support named parameters but don't support the positional ones. On the other hand, it's a driver-specific logic implemented on the wrapper level.

We'll try to take care of that in a different issue. Besides a few nitpicks, looks good.

[morozov]

The idea behind throwing an exception is that in this case, it wouldn't have worked previously anyways, so we're just making the error more explicit. Need to double-check that before merging.

[eisberg]

any news?

[morozov]

@eisberg I forgot about it. Thank you for the reminder.

This is a valid code example that works on 2.9 and a build from this PR:

$stmt = $conn->prepare('SELECT :p FROM DUAL');
$stmt->bindValue('p', 'foo');
$stmt->execute();
echo $stmt->fetchColumn(), PHP_EOL;
// foo

This is an example of invalid code that is not supposed to work:

$stmt = $conn->prepare('SELECT :p FROM DUAL');
$stmt->bindValue(1, 'foo');
$stmt->execute();
echo $stmt->fetchColumn(), PHP_EOL;

On 2.9 it produces:

Warning: oci_bind_by_name(): ORA-01036: illegal variable name/number in lib/Doctrine/DBAL/Driver/OCI8/OCI8Statement.php on line 287
Uncaught Doctrine\DBAL\Driver\OCI8\OCI8Exception: ORA-01008: not all variables bound

On a build from this patch it produces:

Uncaught Doctrine\DBAL\Driver\OCI8\OCI8Exception: Could not find variable mapping with index 1, in the SQL statement

Which is perfectly fine. DBAL prevents a knowingly invalid operation on the underlying driver.

/cc @beberlei (#3779).

[morozov]

@eisberg please rebase your patch onto 2.10. It needs to go there since it's a bugfix. Later, the entire 2.10 branch will be merged into master.

[morozov]

Thank you @eisberg!