Expect only DriverException from Result::fetch*() methods #4093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SenseException the failure is expected. When I was filing the PR, I thought that only the IBMDB2 driver misbehaves but OCI8 misbehaves as well. It needs to be fixed as well. |
|
Is this a draft then? |
morozov
force-pushed
the
expect-driver-exception
branch
from
304ed9f
to
a491b84
Compare
morozov
force-pushed
the
expect-driver-exception
branch
from
a491b84
to
8a74004
Compare
greg0ire
approved these changes
Jul 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test can expect a
DriverExceptionafter #4044 was fixed.