Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use relative names in inline {@link} annotations where possible #4126

Merged
merged 1 commit into from Jun 28, 2020
Merged

Use relative names in inline {@link} annotations where possible #4126

merged 1 commit into from Jun 28, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jun 28, 2020 •
edited

Q A
Type improvement
BC Break no

Some {@link} annotations like the following are highlighted as invalid by PhpStorm:

dbal/lib/Doctrine/DBAL/Driver/AbstractDB2Driver.php

Line 11 in 72b4e77

* Abstract base implementation of the {@link Doctrine\DBAL\Driver} interface for IBM DB2 based drivers.

I assume that in namespaced code, class name reference in inline annotations should follow the same rules as in the rest of phpDoc.

@morozov morozov added this to the 2.10.3 milestone Jun 28, 2020
@morozov morozov merged commit 60f9ff7 into doctrine:2.10.x Jun 28, 2020
@morozov morozov deleted the fix-link-annotations branch June 28, 2020 17:11
@morozov morozov self-assigned this Jun 28, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
Documentation Improvement
Projects
None yet
Milestone
2.10.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @greg0ire