Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated components #4153

Merged
merged 2 commits into from Jul 7, 2020
Merged

Remove deprecated components #4153

merged 2 commits into from Jul 7, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 7, 2020

Q A
Type improvement
BC Break yes

See #4132, #4134.

@morozov morozov added this to the 3.0.0 milestone Jul 7, 2020
@morozov morozov requested a review from greg0ire July 7, 2020 15:47
greg0ire
greg0ire reviewed Jul 7, 2020
View reviewed changes
UPGRADE.md Outdated

The following factory methods of the DBALException class have been removed:

1. `DBALException::invalidPlatformType()`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. `DBALException::invalidPlatformType()`.
1. `DBALException::invalidPlatformSpecified()`.

@morozov morozov requested a review from greg0ire July 7, 2020 19:06
@morozov morozov merged commit 386309c into doctrine:3.0.x Jul 7, 2020
@morozov morozov self-assigned this Jul 7, 2020
@morozov morozov deleted the remove-deprecated branch July 7, 2020 19:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@morozov morozov

Labels
BC Break Connections Error Handling Platforms
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @greg0ire