Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up inconsistent or redundant argument names #4172

Merged
merged 14 commits into from Jul 21, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 17, 2020

Q A
Type improvement
BC Break no

Fixes #4171

  1. The @group legacy and @expectedDeprecation annotations are irrelevant as of Bumped PHPUnit requrement to ^8.3.3, removed dependency on symfony/phpunit-bridge #3643.
  2. The rest of the @group annotations are inconsistent across the test suite and aren't used anywhere.
  3. Arguments have been renamed for consistency between the base declaration and extended implementation.
  4. Argument names have been simplified where possible (e.g. dropTable($tableName)dropTable($name)).
  5. All references to a “field” in the context of the table schema have been replaced with a “column” as more appropriate.

Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@morozov morozov merged commit 0b482cd into doctrine:2.10.x Jul 21, 2020
@morozov morozov self-assigned this Jul 21, 2020
@morozov morozov deleted the argument-name-cleanup branch July 21, 2020 19:20
@morozov morozov mentioned this pull request Jul 2, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent naming of method arguments
2 participants