Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Psalm level to 4 #4319

Merged
merged 10 commits into from Oct 7, 2020
Merged

Bump Psalm level to 4 #4319

merged 10 commits into from Oct 7, 2020

Conversation

morozov
Copy link
Member

@morozov morozov commented Oct 3, 2020

Q A
Type improvement
BC Break no

@morozov morozov added this to the 2.11.2 milestone Oct 3, 2020
@morozov morozov mentioned this pull request Oct 3, 2020
Closed
SenseException
SenseException requested changes Oct 6, 2020
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the relation of the linked PRs in the psalm.xml and how they are connected? Are e.g. the backport removals somehow the reason why these files need to be excluded because they can't be handled right now (BC)?

lib/Doctrine/DBAL/DriverManager.php Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
@morozov
Copy link
Member Author

morozov commented Oct 6, 2020

I don't understand the relation of the linked PRs in the psalm.xml and how they are connected? Are e.g. the backport removals somehow the reason why these files need to be excluded because they can't be handled right now (BC)?

Each issue suppressed in the configuration has a reference to the PR where it's fixed in a BC-breaking way, and there's no other way to fix it. After these changes get merged up, those suppressions may be removed (in 3.0 or 4.0 where the corresponding changes were merged).

@morozov morozov merged commit c361b36 into doctrine:2.11.x Oct 7, 2020
@morozov morozov deleted the psalm-4 branch October 7, 2020 19:53
@morozov morozov self-assigned this Oct 7, 2020
This was referenced Oct 10, 2020
Merged
Merged
@github-actions github-actions bot mentioned this pull request Oct 19, 2020
Closed
@morozov morozov mentioned this pull request Nov 5, 2020
Closed
rgrellmann added a commit to Rossmann-IT/dbal that referenced this pull request Mar 7, 2021
@rgrellmann
Merge tag '2.11.2' into oracle122
406efd5 
Release [2.11.2](https://github.com/doctrine/dbal/milestone/81)

2.11.2
======

- Total issues resolved: **5**
- Total pull requests resolved: **16**
- Total contributors: **10**

Static Analysis
---------------

 - [4353: Update Psalm to 3.17.2 and lock the version used with GitHub Actions](doctrine#4353) thanks to @morozov
 - [4348: Bump Psalm level to 3](doctrine#4348) thanks to @morozov
 - [4332: Static analysis improvements](doctrine#4332) thanks to @morozov
 - [4319: Bump Psalm level to 4](doctrine#4319) thanks to @morozov

Code Style
----------

 - [4346: Minor CS improvement - use ::class for TestCase::expectException input](doctrine#4346) thanks to @mvorisek

 - [4344: Static analysis workflow](doctrine#4344) thanks to @greg0ire
 - [4340: Modernize existing ga](doctrine#4340) thanks to @greg0ire
 - [4309: Use cache action v2](doctrine#4309) thanks to @greg0ire
 - [4305: Move website config to default branch](doctrine#4305) thanks to @SenseException

Improvement,Prepared Statements
-------------------------------

 - [4341: Add Statement::fetchAllIndexedAssociative() and ::iterateIndexedAssociative()](doctrine#4341) thanks to @morozov and @ZaneCEO
 - [4338: Add Statement::fetchAllKeyValue() and ::iterateKeyValue()](doctrine#4338) thanks to @morozov

BC Fix,Query
------------

 - [4330: Fix regression in QueryBuilder::and|orWhere()](doctrine#4330) thanks to @BenMorel

Test Suite
----------

 - [4321: Update PHPUnit to 9.4](doctrine#4321) thanks to @morozov

Columns,SQL Server,Schema Managers
----------------------------------

 - [4315: Fix handling existing SQL Server column comment when other properties change](doctrine#4315) thanks to @trusek

CI
--

 - [4310: Migrate jobs away from Travis to Github Actions ](doctrine#4310) thanks to @greg0ire

BC Fix,Connections
------------------

 - [4308: doctrine#4295 Keep master, slaves, keepReplica params in MasterSlaveConnection](doctrine#4308) thanks to @kralos

New Feature,Prepared Statements
-------------------------------

 - [4289: Add a fetch mode methods for "PDO::FETCH&doctrine#95;KEY&doctrine#95;PAIR"](doctrine#4289) thanks to @tswcode

Bug,SQL Server,Schema
---------------------

 - [3400: Wrong column comment setting command in migrations of SQL Server](doctrine#3400) thanks to @msyfurukawa

# gpg: Signature made Mon Oct 19 04:18:17 2020
# gpg:                using DSA key 1BEDEE0A820BC30D858F9F0C2C3A645671828132
# gpg: Can't check signature: No public key
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SenseException SenseException SenseException approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees

@morozov morozov

Labels
Static Analysis
Projects
None yet
Milestone
2.11.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @SenseException