Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Connection::$_schemaManager and ::getSchemaManager() #4518

Merged
merged 1 commit into from Mar 8, 2021
Merged

Remove Connection::$_schemaManager and ::getSchemaManager() #4518

merged 1 commit into from Mar 8, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Feb 28, 2021 •
edited

Q A
Type improvement
BC Break yes
Fixed issues #4515

@morozov morozov added this to the 4.0.0 milestone Feb 28, 2021
@morozov morozov linked an issue Feb 28, 2021 that may be closed by this pull request
Memory/resource leaks in the wrapper connection #4515
Closed
@morozov morozov mentioned this pull request Feb 28, 2021
Merged
@SenseException
Copy link
Member

The last 3.x branch should introduce a createSchemaManager() and deprecate getSchemaManager(). createSchemaManager() is a more appropriate name for 4.0.x.

@morozov
Copy link
Member Author

morozov commented Feb 28, 2021

Agree. We should do the same for getExpressionBuilder().

@morozov morozov mentioned this pull request Mar 2, 2021
Merged
@morozov morozov marked this pull request as draft March 2, 2021 20:35
@morozov morozov force-pushed the issues/4515 branch 3 times, most recently from 2bf08c9 to 97b9973 Compare March 8, 2021 19:55
@morozov morozov changed the title Remove Connection::$_schemaManager Remove Connection::$_schemaManager and ::getSchemaManager() Mar 8, 2021
@morozov morozov requested review from greg0ire and SenseException and removed request for greg0ire March 8, 2021 20:21
@morozov morozov marked this pull request as ready for review March 8, 2021 20:21
@morozov morozov merged commit 23f29da into doctrine:4.0.x Mar 8, 2021
@morozov morozov deleted the issues/4515 branch March 8, 2021 21:02
@morozov morozov mentioned this pull request Jan 22, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException SenseException approved these changes

Assignees
No one assigned
Labels
BC Break Bug Connections Schema Management
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Memory/resource leaks in the wrapper connection
3 participants
@morozov @SenseException @greg0ire