Backport changes from 4.x and 3.x to avoid memory leaks #4654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzkoshi
changed the title
morozov
reviewed
May 17, 2021
| @@ -218,8 +211,6 @@ public function __construct( | |||
| $this->_config = $config; | |||
| $this->_eventManager = $eventManager; | |||
|
|
|||
| $this->_expr = new Query\Expression\ExpressionBuilder($this); | |||
There was a problem hiding this comment.
This would be a BC break (see #4516). That's why the issue is fixed only in the next major release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport changes from 3.x and 4.x. to 2.13.x.
The main idea to copy the changes down to this version is that the official package for the ORM part does not support 3.x yet.
So this fixes the memory leak in the DBAL part.
I'm not very familiar with the codebase, so if there is something more that have to be done - please, let me know.