Make Table::removeUniqueConstraint() actually work #4667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
previously approved these changes
Jun 6, 2021
SenseException
previously approved these changes
Jun 6, 2021
Table::removeUniqueConstraint() used the wrong method (hasForeignKey()) instead of hasUniqueConstraint() to check for existing unique constraint, causing removeUniqueConstraint() to fail unconditionally. Also adding tests for removeUniqueConstraint().
greg0ire
force-pushed
the
fix-removeUniqueConstraint-wrong-method
branch
from
fc3e68c
to
0e398ec
Compare
greg0ire
approved these changes
Jun 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Table::removeUniqueConstraint() used the wrong method (hasForeignKey()) instead of hasUniqueConstraint() to check for existing unique constraint, causing removeUniqueConstraint() to fail unconditionally.
Also adding tests for removeUniqueConstraint().