Handle lost connection during commit #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
force-pushed
the
issues/4522
branch
2 times, most recently
from
83718ce
to
ab04931
Compare
greg0ire
reviewed
Jul 15, 2021
tests/Functional/TransactionTest.php
Outdated
| $this->iniSet('error_reporting', (string) (E_ALL & ~E_WARNING)); | ||
|
|
||
| $this->expectException(ConnectionLost::class); | ||
| $this->connection->commit(); |
There was a problem hiding this comment.
How hard would it be to also cover the rollBack scenario? Wouldn't it be a simple as calling rollBack here?
There was a problem hiding this comment.
Yea, I think so (assuming that the extensions report the disconnect). Let me update the test.
There was a problem hiding this comment.
Apparently, not 🚀 . We need to fix #4718 first.
greg0ire
approved these changes
Jul 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4522.
The improvement relies on the breaking API changes introduced in #3486 (
4.0.x) and thus cannot be backported to earlier releases as is.TransactionTestbeing introduced already exists in the older branches but it looks like it was mistakenly dropped during the merge up in #3712.