Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPStan check fails on PHP 8 #4717

Merged
merged 1 commit into from
Jul 15, 2021
Merged

PHPStan check fails on PHP 8 #4717

merged 1 commit into from
Jul 15, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Jul 15, 2021

Q A
Type improvement
BC Break no

Fixes #4538:

  1. Remove the assertion after array_combine() since none of the static analysis tools flag it as unsafe any longer.
  2. Suppress OCI8-related errors until the PHP 7 support is dropped (see Being able to check against a range of PHP versions rather then current runtime phpstan/phpstan#4679 (comment)).

Once the PHP 7 support is dropped, we'll need to adjust some OCI8-related assertions. Not worth doing it right now since it would require suppressing more false positives for Psalm.

@morozov morozov added this to the 3.1.2 milestone Jul 15, 2021
@morozov morozov marked this pull request as ready for review July 15, 2021 18:56
@morozov morozov requested a review from greg0ire July 15, 2021 18:56
@morozov morozov merged commit 7267ad3 into doctrine:3.1.x Jul 15, 2021
@morozov morozov deleted the issues/4538 branch July 15, 2021 19:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHPStan check fails on PHP 8
2 participants