Fix auto_increment implementation for Oracle #4733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morozov
reviewed
Jul 26, 2021
morozov
reviewed
Jul 26, 2021
|
@mondrake do you mind if I update the test myself and push it to your branch? Otherwise, the review is taking too much time on my end. |
|
Not at all, you’re welcome |
Co-authored-by: Sergei Morozov <morozov@tut.by>
morozov
changed the title
morozov
approved these changes
Jul 31, 2021
|
Thanks, @mondrake. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4725.
Obviously, different behavior per platform is not something very attractive, but at least with this MR we make Oracle behave like MySql and SQLite, and add tests for all the platforms (except MS Sql that does not allow arbitrary values in INSERT for identity columns).