Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix introspection of BINARY columns #4766

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Fix introspection of BINARY columns #4766

merged 1 commit into from
Aug 29, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Aug 28, 2021 •
edited

Q A
Type bug
BC Break no

Fixes #4761.

  1. Refactor SchemaManagerFunctionalTestCase::testListTableWithBinary() to minimize the discrepancy in the test logic across platforms.
  2. Enable the test for IBM DB2.
  3. Fix introspection on Oracle, SQL Server and IBM DB2.

@morozov morozov changed the title Fix introspection of BINARY columns on Oracle Fix introspection of BINARY columns Aug 28, 2021
@morozov morozov added this to the 3.1.2 milestone Aug 28, 2021
@morozov morozov marked this pull request as ready for review August 28, 2021 21:42
@morozov morozov requested a review from greg0ire August 28, 2021 21:42
@morozov morozov merged commit 9699066 into doctrine:3.1.x Aug 29, 2021
@morozov morozov deleted the issues/4761 branch August 29, 2021 23:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug IBM DB2 Oracle Schema Introspection SQL Server
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

Oracle schema manager doesn't introspect BINARY column length
2 participants
@morozov @greg0ire