Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent table columns as list in the order of declaration #4777

Merged
merged 1 commit into from Sep 11, 2021
Merged

Represent table columns as list in the order of declaration #4777

merged 1 commit into from Sep 11, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 8, 2021 •
edited

Q A
Type improvement
BC Break yes

Fixes #3589. From #3583:

Right now, column names are contained both in array keys and the actual definitions which creates an ambiguity which is a potential source of issues. The proposal is to not rely on the keys and always use the name from the column definition as the single source of truth.

TODO:

@morozov morozov added this to the 4.0.0 milestone Sep 8, 2021
@morozov morozov force-pushed the issues/3589-column-names-as-list branch from b8d00c5 to ab64742 Compare September 8, 2021 02:08
@morozov morozov changed the title Represent table column names as list Represent table columns as list Sep 8, 2021
@morozov morozov force-pushed the issues/3589-column-names-as-list branch from ab64742 to 922f752 Compare September 8, 2021 15:19
@morozov morozov changed the title Represent table columns as list Represent table columns as list in the order of declaration Sep 9, 2021
@morozov morozov force-pushed the issues/3589-column-names-as-list branch from 922f752 to 6df1f0b Compare September 9, 2021 23:20
@morozov morozov marked this pull request as ready for review September 10, 2021 00:47
greg0ire
greg0ire previously approved these changes Sep 11, 2021
View reviewed changes
@morozov morozov force-pushed the issues/3589-column-names-as-list branch from 6df1f0b to f83121f Compare September 11, 2021 15:02
@morozov morozov mentioned this pull request Sep 11, 2021
Merged
@morozov morozov merged commit 2cb1c8c into doctrine:4.0.x Sep 11, 2021
@morozov morozov deleted the issues/3589-column-names-as-list branch September 11, 2021 15:55
@morozov morozov linked an issue Sep 12, 2021 that may be closed by this pull request
Evaluate if we can get rid of the column name index in Doctrine\DBAL\Schema\Table #3589
Closed
@morozov morozov mentioned this pull request Sep 27, 2021
Merged
@morozov morozov mentioned this pull request May 6, 2022
Merged
@morozov morozov mentioned this pull request Jul 26, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
BC Break Improvement Schema
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

Evaluate if we can get rid of the column name index in Doctrine\DBAL\Schema\Table
2 participants
@morozov @greg0ire