Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Oracle test suite #481

Merged
merged 3 commits into from Dec 30, 2013
Merged

Fix Oracle test suite #481

merged 3 commits into from Dec 30, 2013

Conversation

deeky666
Copy link
Member

Final fixes for the Oracle test suite to run again without errors:

deeky@98N-MUELLER-STEVE:~/dev/doctrine/dbal$ phpunit -c oci8.phpunit.xml
PHPUnit 3.7.27 by Sebastian Bergmann.

Configuration read from /home/deeky/dev/doctrine/dbal/oci8.phpunit.xml

..........................................................SSS   61 / 1578 (  3%)
S.............................S.SS...SSSSSSSSSSSSSS.S.SSSSS..  122 / 1578 (  7%)
..SSS.....................SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS  183 / 1578 ( 11%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS..........S.......S  244 / 1578 ( 15%)
......SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS  305 / 1578 ( 19%)
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS  366 / 1578 ( 23%)
S..SSS..SS.S.........................S.......................  427 / 1578 ( 27%)
.............................................................  488 / 1578 ( 30%)
.............................................................  549 / 1578 ( 34%)
.............................................................  610 / 1578 ( 38%)
...........................................................S.  671 / 1578 ( 42%)
.............................................................  732 / 1578 ( 46%)
.....................................S......S................  793 / 1578 ( 50%)
.............................................................  854 / 1578 ( 54%)
......................S.....S................................  915 / 1578 ( 57%)
.............................................................  976 / 1578 ( 61%)
............................................................. 1037 / 1578 ( 65%)
............................................................. 1098 / 1578 ( 69%)
.......................................................SSS... 1159 / 1578 ( 73%)
............................................................. 1220 / 1578 ( 77%)
............................................................. 1281 / 1578 ( 81%)
............................................................. 1342 / 1578 ( 85%)
................S............................................ 1403 / 1578 ( 88%)
............................................................. 1464 / 1578 ( 92%)
.....S..SSS.................................................. 1525 / 1578 ( 96%)
.....................................................

Time: 2.19 minutes, Memory: 50.25Mb

OK, but incomplete or skipped tests!
Tests: 1578, Assertions: 2852, Skipped: 246.

Changes

  • Skip tests for unsupported rollback of DDL statements during transactions
  • Fix default NULL value (again) containing trailing whitespace when retrieved from database
  • Fix drop and create database test by utilizing temporary connection in favour of real connection which has sufficient privileges and changing database name to match Oracle 12c requirements

And finally... HALLELUJAH! 馃憤

@doctrinebot
Copy link

Hello,

thank you for creating this pull request. I have automatically opened an issue
on our Jira Bug Tracker for you. See the issue link:

http://www.doctrine-project.org/jira/browse/DBAL-748

We use Jira to track the state of pull requests and the versions they got
included in.

beberlei added a commit that referenced this pull request Dec 30, 2013
@beberlei
Merge pull request #481 from deeky666/fix-oracle-test-suite
0ae49f5 
Fix Oracle test suite
@beberlei beberlei merged commit 0ae49f5 into doctrine:master Dec 30, 2013
stof
stof reviewed Dec 30, 2013
View reviewed changes
tests/Doctrine/Tests/DBAL/Functional/Schema/OracleSchemaManagerTest.php
$databases = $this->_sm->listDatabases();
$databases = \array_map('strtolower', $databases);

$this->assertEquals(true, \in_array('c##test_create_database', $databases));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beberlei these \ should be removed (and the assertion should probably be changed to assertContains to have a better error message on failure)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeky666 can you do that and commit the change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof @beberlei Yes sorry for that. I just copied that from the base functional test class. I will change that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deeky666 if this code is copied from another place, please fix it in both locations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stof This was my intention ;)

@deeky666 deeky666 mentioned this pull request Dec 30, 2013
Merged
This was referenced Dec 6, 2015
Closed
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deeky666 @doctrinebot @beberlei @stof