Run tests on PHP 8.1 with different database drivers #4875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as draft because I expect tests to fail. |
derrabus
force-pushed
the
ci/database-drivers-php-8.1
branch
from
9520777
to
443866b
Compare
derrabus
commented
Oct 15, 2021
| @@ -434,7 +433,7 @@ jobs: | |||
| coverage: "pcov" | |||
| ini-values: "zend.assertions=1" | |||
| tools: "pecl" | |||
| extensions: "${{ matrix.extension }}-5.9.0preview1" | |||
| extensions: "${{ matrix.extension }}-5.10.0beta1" | |||
There was a problem hiding this comment.
Earlier releases of the driver are not compatible with PHP 8.1.
derrabus
force-pushed
the
ci/database-drivers-php-8.1
branch
from
443866b
to
840caef
Compare
derrabus
force-pushed
the
ci/database-drivers-php-8.1
branch
from
840caef
to
5094ab3
Compare
|
Tests are green. As usual, we need to adjust the branch protection rules. |
morozov
approved these changes
Oct 15, 2021
|
|
||
| public static function upcast(mysqli_sql_exception $exception): self | ||
| { | ||
| $p = new ReflectionProperty(mysqli_sql_exception::class, 'sqlstate'); |
There was a problem hiding this comment.
I'm wondering, what the idea behind the mysqli_sql_exception API design is 🤔
There was a problem hiding this comment.
Yeah. A protected property without any accessors is a really brilliant idea.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've bumped all PHP 8.0 jobs for individual database drivers to PHP 8.1 to uncover issue that we might have there. If you think that testing on PHP 8.0 additionally provides extra value, I can re-add those jobs again. But for now, I did not want to bloat the test matrix further.
Fixes #4870