PHPStan 1.0.2 #4943
PHPStan 1.0.2 #4943
Conversation
| - | ||
| message: '~^Parameter #2 \$count of function array_fill expects int<0, max>, int given\.$~' | ||
| message: '~Method Doctrine\\DBAL\\Driver\\Mysqli\\MysqliStatement::rowCount\(\) should return int but returns int\|string\.~' |
There was a problem hiding this comment.
@morozov This error seems to be raised because of the stub you contributed in phpstan/phpstan-src#700.
The mysqli_stmt::$affected_rows property is documented as int|string which is also what the documentation on php.net says. The documentation does not say in which cases we can expect a string here, but my guess is that this happens if the number of affected rows is larger than PHP_INT_MAX.
However, this also applies to mysqli_stmt::$num_rows which your stub documents as 0|positive-int.
There was a problem hiding this comment.
So the stub probably should be 0|positive-int|string, as well as the return type in the DBAL driver.
There was a problem hiding this comment.
I.e. we also need to change the @return annotation on (Statement|Result)::rowCount() from int to int|string because it will return a string if the value is greater than PHP_INT_MAX.
There was a problem hiding this comment.
This is a bit of a problem because on 3.1.x, we already have an int return type declaration.
There was a problem hiding this comment.
I see. Then I think it's acceptable. Unlike the discussion in doctrine/orm#8963 (comment), updating or deleting a number of rows larger than PHP_INT_MAX is close to impossible.
derrabus
force-pushed
the
bump/phpstan-on-2.13
branch
from
c6e163f
to
52eb197
Compare
derrabus
force-pushed
the
bump/phpstan-on-2.13
branch
from
52eb197
to
2dc8ff1
Compare
| - | ||
| message: '~^Parameter #2 \$count of function array_fill expects int<0, max>, int given\.$~' | ||
| message: '~Method Doctrine\\DBAL\\Driver\\Mysqli\\MysqliStatement::rowCount\(\) should return int but returns int\|string\.~' |
There was a problem hiding this comment.
So the stub probably should be 0|positive-int|string, as well as the return type in the DBAL driver.
derrabus
force-pushed
the
bump/phpstan-on-2.13
branch
3 times, most recently
from
6362aff
to
255ad58
Compare
derrabus
force-pushed
the
bump/phpstan-on-2.13
branch
2 times, most recently
from
8e21a5d
to
a39bfc8
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
derrabus
force-pushed
the
bump/phpstan-on-2.13
branch
from
a39bfc8
to
fd088f1
Compare
|
Thanks @derrabus ! |
Summary
I've bumped PHPStan to the new 1.0.0 and made the necessary adjustments.
I've also tried out the new level 9 and decided that we probably can live with level 8 on old branches. 馃槆