Use willReturn() in mocks instead of will(returnValue()) #4954
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calls like
$mock->will($this->returnValue($value))
are unnecessary verbose and may cause conflicts with4.0.x
which enforces static calls asself::returnValue()
.Using the shortcut consistently will make it simpler to identify the no longer needed mocks in
4.0.x
where PHPUnit will be able to generate them automatically based on the method return type.