Add Connection::getNativeConnection()
#5037
Conversation
derrabus
force-pushed
the
improvement/native-connection
branch
from
0719d37
to
5f822e5
Compare
| $this->connect(); | ||
|
|
||
| assert($this->_conn !== null); | ||
| if (! method_exists($this->_conn, 'getNativeConnection')) { |
There was a problem hiding this comment.
Would it make sense to introduce a deprecated interface extending Connection and implement it where possible? In the next major, it will be merged with the driver-level Connection.
There was a problem hiding this comment.
This will make it hard to implement a middleware in a third-party library that is compatible with DBAL 3.2, 3.3 and 4.0 at the same time. That middleware would have to implement an interface that does not exist in all versions.
There was a problem hiding this comment.
It might be easier to backport the new interface to 3.2.x and make the code better typed but I don't have a strong preference. The reasoning above makes sense.
There was a problem hiding this comment.
Thinking about it, the introduction of the abstract middleware classes has opened up the path for the deprecated interface idea, I guess. A middleware would conditionally implement that interface via the abstract class.
There was a problem hiding this comment.
But isn't the abstract class only available in 3.3.x as well?
There was a problem hiding this comment.
True, but we would be able to build middlewares on 3.3 that are forward compatible with 4.0. That would be sufficient for me at least.
This is a different problem. If we want to use native driver capabilities for case conversion, case conversion should be part of the driver API, not an external wrapper. Once instructed to convert column case, the driver should either do it natively or delegate it to a userland implementation. With this approach, there will be no need to use the native connection outside of the driver. |
derrabus
force-pushed
the
improvement/native-connection
branch
from
5f822e5
to
b06a406
Compare
derrabus
force-pushed
the
improvement/native-connection
branch
from
b06a406
to
2d338a7
Compare
I've merged the other PR and rebased this one. The new method is now implemented in |
derrabus
force-pushed
the
improvement/native-connection
branch
from
2d338a7
to
6682bbd
Compare
derrabus
force-pushed
the
improvement/native-connection
branch
from
6682bbd
to
c8b05b0
Compare
derrabus
force-pushed
the
improvement/native-connection
branch
from
c8b05b0
to
d9f969b
Compare
…derrabus) This PR was merged into the 5.3 branch. Discussion ---------- [Messenger] Leverage DBAL's getNativeConnection() method | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Doctrine DBAL 3 introduced a new driver middleware system that makes it difficult to unwrap the native PDO connection which we need for Messenger's Postgres transport. If an application would actually make use of the middleware system, accessing the PDO connection would become impossible for us. Because of that, I have added a method `getNativeConnection()` to DBAL with doctrine/dbal#5037. This PR leverages this new method. Commits ------- cde5ec7 Leverage DBAL's getNativeConnection() method
Summary
As discussed on #4966, accessing the native connection is a rare but valid use-case.
Unpacking the native connection is tedious and fragile. And with the middleware system, it gets close to impossible to access the native connection. Even our own portability middleware will fail to access it if we move it higher in the middleware stack.
Making the native connection accessible through a userland middleware as suggested in #4966 won't work reliably either because that middleware would have to be registered pretty low in the middleware stack. As soon as there's a lower middleware that wraps the connection, our userland middleware would fail. Our middleware would basically have the same problem as the portability middleware.
This PR proposes to standardize the access to the native connection by adding dedicated methods to the
Connectionclass and the drivers'Connectioninterface. It also deprecates various old accessors from driver connection implementations.