Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Connection::getWrappedConnection(), make Connection::connect() protected #5041

Merged
merged 1 commit into from Nov 28, 2021
Merged

Remove Connection::getWrappedConnection(), make Connection::connect() protected #5041

merged 1 commit into from Nov 28, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Nov 27, 2021

Q A
Type improvement
BC Break yes

See #4966.

@morozov morozov closed this Nov 27, 2021
@morozov morozov reopened this Nov 27, 2021
@morozov morozov force-pushed the remove-get-wrapped-connection branch from b27cf27 to 7532edd Compare November 27, 2021 23:48
@morozov morozov added this to the 4.0.0 milestone Nov 27, 2021
@morozov morozov marked this pull request as ready for review November 28, 2021 02:54
@morozov morozov merged commit a0030f4 into doctrine:4.0.x Nov 28, 2021
@morozov morozov deleted the remove-get-wrapped-connection branch November 28, 2021 02:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire Awaiting requested review from greg0ire

Assignees
No one assigned
Labels
BC Break Connections
Projects
None yet
Milestone
4.0.0-beta1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@morozov @derrabus