Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the doctrine-dbal binary #5084

Merged
merged 1 commit into from Dec 4, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Dec 4, 2021

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

As discussed in #5076, the binary is rarely helpful. In most cases, it's prominent exposure through Composer's vendor/bin directory causes mostly confusion.

@derrabus derrabus added this to the 3.3.0 milestone Dec 4, 2021
@morozov
Copy link
Member

morozov commented Dec 4, 2021

Oh… for the first two times I read the subject as "Deprecate the Doctrine DBAL library".

Should we deprecate the commands under the Doctrine\DBAL\Tools\Command namespace and the ConsoleRunner as well?

@derrabus derrabus changed the title Deprecate the Doctrine DBAL binary Deprecate the doctrine-dbal binary Dec 4, 2021
@derrabus
Copy link
Member Author

derrabus commented Dec 4, 2021

Oh… for the first two times I read the subject as "Deprecate the Doctrine DBAL library".

That was my plan after the 4.0 release, so that 5.0 is basically an empty package. 😅

I changed the title. 🙂

Should we deprecate the commands under the Doctrine\DBAL\Tools\Command namespace and the ConsoleRunner as well?

As I said already, at least one of the two commands is valuable from my point of view. The ConsoleRunner is just a bit of boilerplate for boostrapping a console application around the commands. With the binary gone, I don't see any reason to remove the console tools. They have low complexity and are not in our way really.

@morozov
Copy link
Member

morozov commented Dec 4, 2021

I need to re-read your answer. I thought that by documenting the ways to build a commend, we can remove them from the package and thereby get rid of the dependency on symfony/console.

@derrabus derrabus merged commit 4d66064 into doctrine:3.3.x Dec 4, 2021
@derrabus derrabus deleted the deprecate/dbal-binary branch December 4, 2021 22:43
@morozov
Copy link
Member

morozov commented Mar 28, 2022

Answered in #5076 (comment).

@morozov
Copy link
Member

morozov commented Mar 28, 2022

It looks like there hasn't been a follow-up patch that would remove the deprecated code from 4.0.x. Would you mind submitting one, @derrabus?

@derrabus
Copy link
Member Author

Right, I totally forgot about this one. #5337

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants