Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate support for MariaDB 10.2.6 and older #5102

Merged
merged 1 commit into from Dec 9, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Dec 7, 2021

Q A
Type deprecation
BC Break no

This is an addendum to #5097.

The DBAL uses a separate platform class for MariaDB 10.2.7 and newer:

if ($mariadb && version_compare($this->getMariaDbMysqlVersionNumber($version), '10.2.7', '>=')) {
return new MariaDb1027Platform();

Although the 10.2 release series will be supported until May 2022, MariaDB 10.2.6 was released in May 2017, so those who still use one of the 10.2 releases likely use version 10.2.7 or newer.

If we deprecate only 10.1 and test the remaining supported versions on CI starting with the 10.2 docker image tag (which currently is an alias for 10.2.41), the support for the releases 10.2.0 through 10.2.6 will be effectively untested.

Keeping a separate set of build jobs for testing a 4-years old release seems unjustified. By the time when DBAL 4.0 is released, we will likely drop the support for the entire 10.2 series anyways.

@morozov morozov merged commit 2b3504f into doctrine:3.3.x Dec 9, 2021
@morozov morozov deleted the deprecate-mariadb-10.2.6 branch December 9, 2021 01:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants